Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use explicit typing for lexer lookahead #126

Merged
merged 1 commit into from
Mar 28, 2022
Merged

use explicit typing for lexer lookahead #126

merged 1 commit into from
Mar 28, 2022

Conversation

the-mikedavis
Copy link
Contributor

Checklist: ✅

  • All tests pass in CI
  • There are sufficient tests for the new fix/feature (N/A)
  • Grammar rules have not been renamed unless absolutely necessary (0 rules renamed)
  • The conflicts section hasn't grown too much (0 new conflicts)
  • The parser size hasn't grown too much (master: 2330, PR: 2330)

👋 hello!

The auto typing is problematic for older c++ toolchains. In my case, it fails to cross-compile from x86_64-linux to aarch64-linux because of an old compiler. Declaring the type explicitly works fine though. What do you think?

@patrickt
Copy link
Contributor

LGTM.

@patrickt patrickt merged commit 4b56881 into tree-sitter:master Mar 28, 2022
@the-mikedavis the-mikedavis deleted the md-no-auto branch March 28, 2022 16:34
@yvt yvt mentioned this pull request Jul 29, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickt patrickt patrickt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-mikedavis @patrickt